break up create_clean_reported_cases()
#884
Merged
+402
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seabbs
reviewed
Dec 9, 2024
seabbs
previously approved these changes
Dec 9, 2024
seabbs
reviewed
Dec 9, 2024
Co-authored-by: Sam Abbott <[email protected]>
Co-authored-by: Sam Abbott <[email protected]>
seabbs
previously approved these changes
Dec 9, 2024
seabbs
previously approved these changes
Dec 9, 2024
|
I think there is an issue with the message formatting in the depreciation note. |
|
Might be a task for a separate issue but maybe we should showcase these functions in the examples of the exported functions. |
Co-authored-by: James Azam <[email protected]>
Co-authored-by: James Azam <[email protected]>
|
Passing tests now so just needs someone to approve to enter the merge queue @seabbs @jamesmbaazam |
jamesmbaazam
approved these changes
Dec 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #346 by breaking up the
create_clean_reported_cases()function into its individual steps that are now separate functions that can be applied at preprocessing stage. After a deprecation cycle this function will be removed.Doing so will facilitate addressing #640 via the new
add_horizon()function that allows users to specify a forecast interval (internal for now, could later be exposed or accessed viaforecast_opts()or the like when addressing #867).It will also facilitate addressing #451 as data passed to functions can be used for plotting as preprocessing happens before calling
estimate_infections()and the like.Initial submission checklist
devtools::test()anddevtools::check()).devtools::document()).lintr::lint_package()).After the initial Pull Request